This repository was archived by the owner on Aug 21, 2024. It is now read-only.
Configurable webmanifest path #7199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added configuration of site manifest and automatic reupload of manifest.
With the move to hosting client files from the storage provider, the site manifest file was
providing improper paths. The start_path was being read by the client as being under the
storage provider's domain, rather than the client domain, and the icon paths were not correct,
since the convention is to have client files under /client in the storage provider.
Most aspects of the site manifest are now configurable from clientSettings. 'name' uses
clientSettings.title; 'short_name' comes from a new field, clientSettings.shortTitle;
'start_url' explicitly adds a new field clientSettings.startPath onto config.client.url;
and the two icons are combined from clientSettings.icon192px and clientSettings.icon512px
with the cacheDomain.
client-setting.patch now pulls down the manifest from the storage provider, updates it with the
patched data, and pushes it back to the storage provider. The same basic thing is done during
run-builder.sh in a new script update-site-manifest.ts, but instead of pulling/pushing to the
storage provider, just updates the copy of the file in packages/client/public, as all of that
will be built and pushed to the storage provider in the client build process.
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.