This repository was archived by the owner on Aug 21, 2024. It is now read-only.
Updated JWT authentication to handle RSA signatures#10961
Open
Updated JWT authentication to handle RSA signatures#10961
Conversation
barankyle
requested review from
CITIZENDOT,
DanielBelmes,
HexaField,
MoizAdnan,
SYBIOTE,
aditya-mitra,
hanzlamateen and
hurairahmateen
as code owners
barankyle
force-pushed
the
IR-3827-rsa-key-for-jwt-signing
branch
from
c5d50f3 to
03c36e4
Compare
hanzlamateen
suggested changes
Aug 14, 2024
Contributor
hanzlamateen
left a comment
hanzlamateen
left a comment
There was a problem hiding this comment.
- It seems like some github checks are failing
- Getting following error when running locally.
packages/server-core/src/user/jwt-public-key/jwt-public-key.hooks.ts
Outdated
Show resolved
Hide resolved
New authentication-setting fields for JWT algorithm and JWT public key. Keys should be inserted as strings with '\n' replacing new lines. Replaced the last of the API.instance.client uses with Engine.instance.api Added a new service that will return the JWT public key. Replaced current jsonwebtoken.decode calls with jsonwebtoken.verify. decode does not check if the signature is valid. Resolves IR-3827
barankyle
force-pushed
the
IR-3827-rsa-key-for-jwt-signing
branch
from
03c36e4 to
c40dcd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New authentication-setting fields for JWT algorithm and JWT public key. Keys should be inserted as strings with '\n' replacing new lines.
Replaced the last of the API.instance.client uses with Engine.instance.api
Added a new service that will return the JWT public key.
Resolves IR-3827
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps