Skip to content

Fix ipykernel install #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minrk merged 2 commits into from
Dec 17, 2024
Merged

Fix ipykernel install #1310

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28a72bd
Fix ipykernel install
davidbrochart Dec 16, 2024
007d12f
Don't run kernel if subapp
davidbrochart Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ipykernel/kernelapp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,9 +736,9 @@ def start(self) -> None:
self.subapp.start()
if self.poller is not None:
self.poller.start()
backend = "trio" if self.trio_loop else "asyncio"
run(self.main, backend=backend)
return
if self.kernel is not None:
backend = "trio" if self.trio_loop else "asyncio"
run(self.main, backend=backend)

async def _wait_to_enter_eventloop(self):
await self.kernel._eventloop_set.wait()
Expand Down
Loading