Enable ProactorEventLoop on windows for ipykernel
#1184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
approved these changes
Dec 21, 2023
Contributor
blink1073
left a comment
blink1073
left a comment
There was a problem hiding this comment.
Oh wow, the test suite is about twice as fast, thank you!
This was referenced Dec 26, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows
ipykernelcurrently usesSelectorEventLoopwhich is slower thanProactorEventLoop. this issue causes many apps likevscodeuseipykernelslow.Currently,
ipykernelrequirespythonversion >=3.8 andtornadoversion >= 6.1 (which can already work withProactorEventLoop)So this issue can be fixed now
related:
tornadoweb/tornado#2608
https://www.tornadoweb.org/en/stable/releases/v6.1.0.html
f40d74a