This repository was archived by the owner on Jun 29, 2022. It is now read-only.
feat: allow inline link definitions for kinded unions #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g.
```
type Foo union {
| &Blip link
| Blop string
} representation kinded
```
rather than having to `type BlipLink &Blip` before using it in a
kinded union.
rvagg
force-pushed
the
rvagg/kinded-link-shorthand
branch
from
b22c6c0 to
bf71b7b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g.
rather than having to
type BlipLink &Blipbefore using it in a kinded union.I've been using this pattern already, e.g.
specs/data-structures/hashmap.md
Lines 113 to 116 in 9bab36f
I think I assumed we had this locked in but I guess we never got it into schema-schema. Without this, to use a link to another type you've defined, you have to make a new link type for it
type HashMapNodeLink &HashMapNode.