fix: document CBOR in /reframe?q= #333
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to miscommunication, go-delegated-routing v0.6.0 uses CBOR in `?q` – this updates the spec to describe current pre-alpha implementation.
willscott
approved these changes
Oct 15, 2022
Contributor
willscott
left a comment
willscott
left a comment
There was a problem hiding this comment.
this does appear to reflect reality
maybe worth a comment about spaces being url encoded to '+'s and not being percent encoded? (although it's probably safer to percent encode them first and the decoder will take that as well)
Member
Author
|
This turned out to be a big time sink – existing wire format and implementation has other issues, such as buffering streaming responses due to Etag generation. I am closing this – if we want to fix Reframe we should stop bending backward and changing specs to fix broken implementation – only way forward for Reframe over HTTP is to implement #327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to miscommunication, go-delegated-routing v0.6.0 uses DAG-CBOR in
?q(and not DAG-JSON, like we expected) 🙈Details: ipld/edelweiss#61
This PR updates the spec to describe the current pre-alpha implementation that shipped with Kubo 0.16
TODO: make decision if we change spec, or fix implementation
👉 If we are not planning to surgically fix this SOON (as proposed in ipld/edelweiss#61) I suggest we update specs to reflect implementation