fix(core): look for MFS root in local repo only #8661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@aschmahmann will approve/merge |
aschmahmann
approved these changes
Mar 11, 2022
Contributor
aschmahmann
left a comment
aschmahmann
left a comment
There was a problem hiding this comment.
Looks good, we should have a small sharness test that confirms that this works.
Contributor
Author
|
I tested this locally with the new command in #8648. That seems like the most organic way to add a sharness test for this so will mark it as blocked on that other one (feel free to suggest an alternative test that would keep both independent). |
lidel
force-pushed
the
schomatis/fix/core/mfs-root-localy-only
branch
from
d2cae12 to
131a4e1
Compare
lidel
force-pushed
the
schomatis/fix/core/mfs-root-localy-only
branch
from
131a4e1 to
6d31769
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7183. (The bigger issue of GC/MFS lock is being worked on independently. We close the issue about hanging on startup.)