Convert from callbacks to async #19
Conversation
dirkmc
force-pushed
the
chore/callbacks-to-async
branch
2 times, most recently
from
a3c7cfe to
3329f36
Compare
vasco-santos
left a comment
vasco-santos
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR @dirkmc !
Left a few comments in the review.
Besides that, can you rebase this PR, as we are not using Jenkins CI anymore and I just added the travis config? Also, add a BREAKING CHANGE message in the commit body please.
dirkmc
force-pushed
the
chore/callbacks-to-async
branch
2 times, most recently
from
c14c5d9 to
03ec3d3
Compare
|
Thanks @vasco-santos, I followed your suggestions with one small exception that I replied to |
vasco-santos
added
the
status/blocked
vasco-santos
left a comment
vasco-santos
left a comment
There was a problem hiding this comment.
All in all, this looks good! Added 3 minor details / suggestions!
dirkmc
force-pushed
the
chore/callbacks-to-async
branch
2 times, most recently
from
ff5ed4e to
c85a1b5
Compare
vasco-santos
left a comment
vasco-santos
left a comment
There was a problem hiding this comment.
Looks good! Thanks @dirkmc
The CI is failing as a result of the peer-id being installed through branch uses promises. As a consequence, js-ipfs uses this version as well (but it needs to use the callback version for now). So, once peer-id is released with a breaking change and we install its version here, everything should be fine.
|
@dirkmc can you update this PR? I think all the dependencies are now ready |
BREAKING CHANGE: All places in the API that used callbacks are now replaced with async/await
dirkmc
force-pushed
the
chore/callbacks-to-async
branch
from
6e659b3 to
1cb0063
Compare
2 participants
BREAKING CHANGE: This change replaces callbacks with async / await
Needs the following PRs: