Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Conversation

@daviddias
Copy link
Member

Let's give Node 10 a spin! :)

@ghost ghost assigned daviddias May 29, 2018
@ghost ghost added the status/in-progress In progress label May 29, 2018
"ipfs-block-service": "~0.14.0",
"ipfs-multipart": "~0.1.0",
"ipfs-repo": "~0.20.0",
"ipfs-repo": "~0.22.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobheun CI is not happy with the latest ipfs-repo. How did you run the tests before (ref: ipfs/js-ipfs-repo#168 (comment))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to the ipld PR, ipld/js-ipld#129, that needs released. I will update #1358 once that is done.

The current versioning scheme results in old leveldown being installed for ipld, which breaks the install.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diasdavid I already have a PR open for node 10 that is running tests now, #1358. It also includes the fix for the breaking change in ipfs-repo 0.20.1 ipfs/js-ipfs-repo#165, which is the errors your PR is getting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed that one. I had read from your message that you had tested against js-ipfs master. All good then :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants