Merged
Conversation
not updating the explicit dependency on multihash meant that 0.16.1 was used without the `blake3` feature, breaking the tests
dariusc93
reviewed
Oct 17, 2022
| version = "0.43.0" | ||
| version = "0.48.0" | ||
| default-features = false | ||
| features = [ |
There was a problem hiding this comment.
You might want to enable "rsa" feature since that was moved into its own feature (libp2p/rust-libp2p#2860) otherwise you might run into errors if you use libp2p bootstrap or dialing any rsa keys (libp2p/rust-libp2p#2971). If its not needed, could also move it into a optional feature too.
Contributor
Author
There was a problem hiding this comment.
Thanks for catching this! An optional feature looks like the idiomatic way to go.
rkuhn
commented
Oct 18, 2022
|
|
||
| for addr in config.listen_on { | ||
| let _ = ipfs.listen_on(addr)?; | ||
| let _ = ipfs.listen_on(addr); |
Contributor
Author
There was a problem hiding this comment.
Now that listen failure is asynchronous, perhaps include the notification in SwarmEvents.
Contributor
Author
There was a problem hiding this comment.
leaving this for a later time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bigger update because libp2p removed NetworkBehaviourEventProcess, which means that all state needs to move out of the Behaviour and into the place that calls
poll.As I was touching this code anyway, I removed the mutex-based swarm access and fully encapsulated the Swarm in its own task, making all external requests asynchronous (and also
'static, i.e. owned data, so that they can travel through channels).The result is that some tests broke because they had previously relied upon scheduling artifacts caused by the mutex approach.