fix missing 1 required positional argument bug & sqlite3.operationalerror: database is locked issue #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trinity-SYT-SECURITY
commented
Aug 6, 2024
Trinity-SYT-SECURITY
commented
Trinity-SYT-SECURITY
requested review from
andreashappe and
citostyle
as code owners
Trinity-SYT-SECURITY
changed the title
|
|
||
| def perform_round(self, turn:int) -> bool: | ||
| got_root : bool = False | ||
| def perform_round(self, turn: int) -> bool:##fix code |
| self.log_db.add_log_query(self._run_id, turn, cmd, result, answer) | ||
| self._sliding_history.add_command(cmd, result) | ||
| self.console.print(Panel(result, title=f"[bold cyan]{cmd}")) | ||
| #self.log_db.add_log_query(self._run_id, cmd, result, answer) |
Member
There was a problem hiding this comment.
this looks wrong, wouldn't this only call test_credentials and not execute_command anymore?
| def connect(self): | ||
| self.db = sqlite3.connect(self.connection_string) | ||
| # self.db = sqlite3.connect(self.connection_string, timeout=10) # Set timeout to 10 seconds | ||
| self.db = sqlite3.connect(self.connection_string, check_same_thread=False, timeout=10) |
Member
There was a problem hiding this comment.
this is weird. I am trying to understand the error case. Are you running two instances of hackingBuddyGPT in parallel? This would not be supported by the sqlite3 database (that we are currently using). I think the clean solution would rather be to use a separate sqlite database per run (using the log_db parameter) or using a database such as postgres/mysql that supports concurrent access
Collaborator
|
This should all be handled in #79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.