tools/tcpretrans: add optional tcp seq output #3600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelgugino
requested review from
brendangregg and
goldshtn
as code owners
Contributor
Author
|
I've seen some attempts to get this information across a few issues and am interested in this myself. I also have working code for the libbpf tools version once #3539 merges. |
brendangregg
reviewed
Sep 1, 2021
michaelgugino
force-pushed
the
retrans-seq-py
branch
from
274c037 to
11469d3
Compare
Collaborator
|
[buildbot, test this please] |
Collaborator
|
[buildbot, ok to test] |
Collaborator
yonghong-song
left a comment
yonghong-song
left a comment
There was a problem hiding this comment.
could you also add the option to the man page?
This commit adds the ability to print out tcp sequence numbers while running the tool in normal mode by reading the appropriate fields from skb. skb is not readily available for TLP, thus the output for that mode is set to 0. Signed-off-by: Michael Gugino <[email protected]>
michaelgugino
force-pushed
the
retrans-seq-py
branch
from
11469d3 to
27c8f6f
Compare
Collaborator
|
LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to print out tcp sequence numbers while
running the tool in normal mode by reading the appropriate fields from
skb. skb is not readily available for TLP, thus the output for that mode
is set to 0.
Signed-off-by: Michael Gugino [email protected]