Improve setInterval/setTimeout checks (E5004/E5005) to scan all files and suggest proper usage#560
Draft
Improve setInterval/setTimeout checks (E5004/E5005) to scan all files and suggest proper usage#560
Conversation
…proper usage Co-authored-by: mcm1957 <28575778+mcm1957@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve setInterval / setTimeout checks ([E504/E505]
Improve setInterval/setTimeout checks (E5004/E5005) to scan all files and suggest proper usage
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #182
Overview
This PR significantly improves the setInterval/setTimeout checks (E5004/E5005) to provide better coverage and more helpful guidance to adapter developers. The checks now scan all executable files, intelligently ignore proper usage patterns, and provide context-aware suggestions.
Changes
Previous Behavior
package.json.main) if it ended with.jsNew Behavior
.js,.ts,.mjs, and.cjsfiles in the repositorythis.setInterval(),adapter.setInterval(),this.setTimeout(), andadapter.setTimeout()calls (which are the correct usage patterns)this.*when inside adapter class oradapter.*when outsideError/Warning Codes
setInterval()withoutclearInterval()in compact modesetInterval()withoutclearInterval()in non-compact modesetInterval()withclearInterval()presentsetTimeout()withoutclearTimeout()setTimeout()withclearTimeout()presentExample Output
Before:
After:
Implementation Details
isInAdapterClassContext()function to determine proper contextnode_modules,admin,admin-src,.git,.vscode,.dev-serverTesting
Impact
This improvement helps adapter developers:
.tsfile checkingWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
data.jsdelivr.comnode(dns block)https://api.github.com/repos/ioBroker/ioBroker.javascriptnode index.js REDACTED --local --debug(http block)https://api.github.com/repos/ioBroker/ioBroker.testnode /home/REDACTED/work/ioBroker.repochecker/ioBroker.repochecker/index.js REDACTED --local(http block)https://api.github.com/repos/undefined/git/trees/undefinednode(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.