-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(pnpm): replace npm with pnpm in dockerfile #5295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More pnpm-way version: |
Contributor
Author
|
Ah I see, OK thanks updated. |
antage
reviewed
Dec 18, 2023
antage
approved these changes
Dec 18, 2023
1 task
Contributor
Author
|
As per #5258 - 3.5.0 builds are still failing on rc3, this resolves the issue. |
hipsterusername
approved these changes
Dec 19, 2023
hipsterusername
approved these changes
Dec 19, 2023
Member
|
@sammcj - these are the tiny nudges and changes that keep the whole thing moving. Thanks for the help!! |
Contributor
Author
|
No worries at all, I don't want to come off as pushy / demanding so I'm glad it's taken that way 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
3.5.0 rc1 Docker builds are broken due to the swap from npm to pnpm.
I think this should fix it.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Run docker build and tests as normal.
Merge Plan
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?