Skip to content

Conversation

@sammcj
Copy link
Contributor

@sammcj sammcj commented Dec 15, 2023

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimisation
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • No, because: it's for a version currently in RC

Have you updated all relevant documentation?

  • Yes
  • No

Description

3.5.0 rc1 Docker builds are broken due to the swap from npm to pnpm.

I think this should fix it.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Run docker build and tests as normal.

Merge Plan

  • Can be merged when approved and docker builds pass.

Added/updated tests?

  • Yes
  • No : not relevant?

[optional] Are there any post deployment tasks we need to perform?

@antage
Copy link

antage commented Dec 17, 2023

More pnpm-way version:

FROM node:18-slim AS web-builder
ENV PNPM_HOME="/pnpm"
ENV PATH="$PNPM_HOME:$PATH"
RUN corepack enable

WORKDIR /build
COPY invokeai/frontend/web/ ./
RUN --mount=type=cache,target=/pnpm/store \
    pnpm install --frozen-lockfile
RUN pnpm run build

@sammcj
Copy link
Contributor Author

sammcj commented Dec 18, 2023

Ah I see, OK thanks updated.

@sammcj sammcj requested a review from antage December 18, 2023 06:01
@sammcj
Copy link
Contributor Author

sammcj commented Dec 19, 2023

As per #5258 - 3.5.0 builds are still failing on rc3, this resolves the issue.

@hipsterusername hipsterusername merged commit a4f9bfc into invoke-ai:main Dec 19, 2023
@hipsterusername
Copy link
Member

@sammcj - these are the tiny nudges and changes that keep the whole thing moving. Thanks for the help!!

@sammcj
Copy link
Contributor Author

sammcj commented Dec 19, 2023

No worries at all, I don't want to come off as pushy / demanding so I'm glad it's taken that way 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants