[🐛] `httpsCallable` function may remove null on iOS on old react-native w/new arch (solution: upstream issue, use current react-native)

[tkumor3]

Issue

httpsCallable on iOS removes the JSON property if the value is null. Example:

  firebase
    .app()
    .functions('us-central1')
    .httpsCallable('test')({ arg1: null, arg2: 'arg2' })
    .then();

called on android sent to firebase:

{
  data: {
    arg1: null,
    arg2: 'arg2'
  }
}

on IOS:

{
  data: {
    arg2: 'arg2'
  }
}

---

Project Files

Javascript

Click To Expand

package.json:

  "dependencies": {
    ...
    "@react-native-firebase/app": "^21.11.0",
    "@react-native-firebase/auth": "^21.11.0",
    "@react-native-firebase/crashlytics": "^21.11.0",
    "@react-native-firebase/firestore": "^21.11.0",
    "@react-native-firebase/functions": "^21.11.0",
    "@react-native-firebase/storage": "^21.11.0",
    ...
}

• Platform that you're experiencing the issue on:
  • iOS
  • Android
  • iOS but have not tested behavior on Android
  • Android but have not tested behavior on iOS
  • Both
• react-native-firebase version you're using that has this issue:
  • e.g. 5.4.3
• Firebase module(s) you're using that has the issue:
  • e.g. Instance ID
• Are you using TypeScript?
  • Y/N & VERSION

[SelaseKay]

Hi @tkumor3, I'm able to reproduce this behaviour. I'll investigate further.

[mikehardy]

What version of react-native is in use ? You omitted so much of the requested information in the issue template @tkumor3 - that makes it difficult to pin these things down.

Why is that important? You may be running up against a flavor of this issue #8144 which was an upstream issue in new architecture (facebook/react-native#49250) but should be fixed with react-native 0.77.1+ or 0.78.0

@SelaseKay curious if you were able to reproduce on our e2e app in our current state (which is on react-native 0.77.1 now and should have the fix for iOS new arch null handling). That might help understand if this is an already fixed problem or if we have a new problem

[SelaseKay]

Hi @mikehardy, I reproduced it with our e2e app. However, I just noticed it was tested against RN 0.76. I'll pull the latest changes and test again.

[mikehardy]

I'm betting $1 it is that problem and including the react-native version in the original issue template would have made identifying that take approximately one person a couple minutes vs any extra time spent here. I definitely saw failures in our e2e test harness in functions, for this reason, under new architecture until I collaborated with upstream folks to fix it in react-native. The issue #8144 here has links to patches for react-native 0.76 and 0.77.0 if for whatever reason people are unable to upgrade directly to a version with the fix.

[SelaseKay]

@mikehardy, you were right. This isn't reproducible with React Native 0.77.

[mikehardy]

Good to hear - closing then - template should have been filled out / issues without template should be closed in future, re-openable if information provided. Issues logged against old versions should be requested to reproduce again after upgrading to current versions... working otherwise is inefficient - always the risk of chasing already closed issues