Skip to content

Fix plotting in Plots > v.1.11 #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Fix plotting in Plots > v.1.11 #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2e219c
Fix plotting for Plots > v1.11
Apr 20, 2021
26c86a1
Remove added whitespace
Apr 20, 2021
be44c4a
Remove last element that mark a nan (or placeholder for data)
Sep 3, 2022
bb6d24e
Bump Project
Sep 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name = "Intervals"
uuid = "d8418881-c3e1-53bb-8760-2df7ec849ed5"
license = "MIT"
authors = ["Invenia Technical Computing"]
version = "1.8.0"
version = "1.8.1"

[deps]
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
Expand All @@ -12,6 +12,6 @@ Serialization = "9e88b42a-f829-5b0c-bbe9-9e923198166b"
TimeZones = "f269a46b-ccf7-5d73-abea-4c690281aa53"

[compat]
RecipesBase = "0.7, 0.8, 1"
RecipesBase = "1"
TimeZones = "1.7"
julia = "1.6"
7 changes: 7 additions & 0 deletions src/plotting.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@ interval_marker(x::Type{Open}) = :none
push!(markers, :none)
end

pop!(markers) # Remove the last :none.

# These two are not necessary but keep things consistent
# This is because the segment builder will just look until no more nan
# https://github.com/JuliaPlots/Plots.jl/blob/8265d6ee8f612581b286a51e476e8acfe45adea7/src/utils.jl#L163
pop!(new_ys); pop!(new_xs)

# Work around GR bug that shows :none as a marker
# TODO: remove once https://github.com/jheinen/GR.jl/issues/295 is fixed
markeralpha := [x == :none ? 0 : 1 for x in markers]
Expand Down