refactor: restructure plugin layout for better separation#35
Merged
tylerkrupicka merged 2 commits intointuit:masterfrom Oct 31, 2020
Merged
refactor: restructure plugin layout for better separation#35tylerkrupicka merged 2 commits intointuit:masterfrom
tylerkrupicka merged 2 commits intointuit:masterfrom
Conversation
Contributor
|
Hey @joshtym, I took a glance at this and it looks great! I'll do a more thorough review soon. Thanks for contributing! |
tylerkrupicka
approved these changes
Oct 26, 2020
Contributor
tylerkrupicka
left a comment
tylerkrupicka
left a comment
There was a problem hiding this comment.
This looks good to me! Can you fix the conflicts and then ill work on getting this in?
joshtym
force-pushed
the
restructure-of-plugin
branch
from
d722838 to
7b77782
Compare
Author
Done! |
tylerkrupicka
approved these changes
Oct 31, 2020
3 tasks
Contributor
|
🚀 PR was released in v2.2.1 🚀 |
Contributor
|
Thanks for the contribution @joshtym! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Taking a stab at #20 by splitting the configuration into 4 primary components: common, legacy, modern and types
Why
See issue for the why
Todo:
yarn all-contributors add [name] [type]) see https://github.com/all-contributors/all-contributors/blob/master/docs/cli/usage.md