Fix: Correct Authorization header in makeApiCall method #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The makeApiCall method was incorrectly using spread operator on authHeader()
which returns a string, not an object. This caused the headers object to be
populated with numeric properties for each character of the base64 string,
resulting in malformed HTTP headers and API call failures.
Fixed by properly setting the Authorization header with Bearer token:
Authorization: `Bearer ${this.getToken().access_token}`
This matches the original 4.2.0 implementation and is consistent with other
OAuth methods like getUserInfo().
Resolves issue reported by users after upgrading to 4.2.1 where API calls
started failing due to incorrect header formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The makeApiCall method was incorrectly using spread operator on authHeader() which returns a string, not an object. This caused the headers object to be populated with numeric properties for each character of the base64 string, resulting in malformed HTTP headers and API call failures.
Fixed by properly setting the Authorization header with Bearer token: Authorization:
Bearer ${this.getToken().access_token}This matches the original 4.2.0 implementation and is consistent with other OAuth methods like getUserInfo().
Resolves issue reported by users after upgrading to 4.2.1 where API calls started failing due to incorrect header formatting.