Erase all feature macro definitions for OpenCL 3.0 #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a follow-up on commit de262c9, delete default definitions for all 3.0 feature macros. The motivation is similar to that in the image support macro case - we need to account for target platform features whenever the Clang FE is called in Compute Runtime's context. Signed-off-by: Artem Gindinson <[email protected]>
Author
|
@hewj03 @haonanya Could you please take a look? |
wenju-he
approved these changes
May 11, 2023
Contributor
wenju-he
left a comment
wenju-he
left a comment
There was a problem hiding this comment.
LGTM. Is it right that some device doesn't support one of these deleted feature macro?
Author
|
@hewj03, thank you so much! Yes, these macros belong to "optional core features" per OCL C 3.0 (1), so the behavior is expected for certain platforms. (1) https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_C.html#features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up on commit de262c9, delete default definitions for all 3.0 feature macros. The motivation is similar to that in the image support macro case - we need to account for target platform features whenever the Clang FE is called in Compute Runtime's context.
Signed-off-by: Artem Gindinson [email protected]