[SYCL][NFC] Use Impl objects instead of SYCL objects #941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to use shared pointers to impl objects in fields of *_impl classes to avoid duplication of object creation and avoiding default constructors calls and creation context for unpredictable devices. Signed-off-by: Vladimir Lazarev <[email protected]>
vladimirlaz
force-pushed
the
private/vlazarev/impl
branch
from
f292def to
90cdcfc
Compare
sergey-semenov
approved these changes
Dec 18, 2019
vladimirlaz
pushed a commit
that referenced
this pull request
Mar 30, 2021
* Print path info in error messages only in debug build Signed-off-by: Dmitry Sidorov <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@64be6c6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to use shared pointers to impl objects in fields of *_impl
classes to avoid duplication of object creation and avoiding default
constructors calls and creation context for unpredictable devices.
Signed-off-by: Vladimir Lazarev [email protected]