[SYCL] Fix weak_object on Windows #7642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the following fixes for weak_object and order_less for
Windows:
1. Adds the new ABI symbols.
2. Adds the missing include for std::optional in weak_object.hpp.
3. Fixes a problem where MSVC could not resolve createSyclObjFromImpl
for accessors due to a mismatch in template argument names between
the function declaration and the friend declaration.
4. Enables empty-base optimization on accessor classes inheriting from
OwnerLessBase when compiling with MSVC. This is needed as otherwise
it changes the size of the corresponding classes, which would be an
ABI break.
Signed-off-by: Larsen, Steffen <[email protected]>
romanovvlad
approved these changes
Dec 5, 2022
aelovikov-intel
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the following fixes for weak_object and order_less for Windows: