Skip to content

[SYCL][Reduction] Fix race condition in withAuxHandler #7563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steffenlarsen merged 2 commits into from
Nov 29, 2022
Merged

[SYCL][Reduction] Fix race condition in withAuxHandler #7563

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68dd8ba
[SYCL][Reduction] Fix race condition in withAuxHandler
aelovikov-intel Nov 28, 2022
fb9d19f
Update sycl/include/sycl/reduction.hpp
aelovikov-intel Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sycl/include/sycl/reduction.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,8 +821,9 @@ auto make_reduction(RedOutVar RedVar, RestTy &&...Rest) {
namespace reduction {
inline void finalizeHandler(handler &CGH) { CGH.finalize(); }
template <class FunctorTy> void withAuxHandler(handler &CGH, FunctorTy Func) {
CGH.finalize();
auto E = CGH.finalize();
handler AuxHandler(CGH.MQueue, CGH.MIsHost);
AuxHandler.depends_on(E);
AuxHandler.saveCodeLoc(CGH.MCodeLoc);
Func(AuxHandler);
CGH.MLastEvent = AuxHandler.finalize();
Expand Down