-
Notifications
You must be signed in to change notification settings - Fork 809
Move the Intel specific features to a separate document. Mainly: #7307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
eaca6bf
-Remove dynamic extent. I kept it in the open questions though of the…
dkhaldi 4bf0775
remove comment
dkhaldi cc99697
Add an open question for adding a constructor with no argument
dkhaldi e673549
address Jack's comments
dkhaldi 687ff28
Address more comments from Jack
dkhaldi 9fb5b05
More cleanup of the non unified parts
dkhaldi cc6f846
Add packed layout and store flexibility to the Intel extension
dkhaldi d92ca02
Rename sycl_ext_oneapi_intel_matrix.asciidoc to sycl_ext_intel_matrix…
dkhaldi b3c3402
Improve the query API by adding XMX of PVC and other improvements spe…
dkhaldi e3ee0ea
reorder Group and layout parameters, make get_wi_data free function a…
dkhaldi f3050a8
Remove Open Questions section that has one item already resolved:
dkhaldi 74217b9
Address Jack's comments
dkhaldi 96aaa2f
Add information about the combinations that the implementation suppor…
dkhaldi e8d1646
format
dkhaldi 88906a2
format
dkhaldi e9f5366
format
dkhaldi 10477a4
Incorporate Jinsong's corrections
dkhaldi 4582fb3
format <= sign in the supported sizes
dkhaldi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -35,16 +35,14 @@ SYCL specification refer to that revision. | |||||
| **_NOTE:_** This document describes extra features and details for the implementation of `joint_matrix` extension on Intel AMX and Intel XMX. | ||||||
|
|
||||||
| ## Introduction | ||||||
| The Intel backend implementations on both Intel AMX and DPAS support `joint_matrix`, `joint_matrix_load`, `joint_matrix_store`, `joint_matrix_mad`, `joint_matrix_fill`, `get_wi_data`, and the query interface, as they are defined in the sycl_ext_oneapi_matrix extension. There are exra specifics about the supported layouts for extra performance and functionality that are listed in this document. | ||||||
|
|
||||||
| // I don't think we need a specific feature test macro because there is not really additional features. | ||||||
| The Intel backend implementations on both Intel AMX and Intel XMX support `joint_matrix`, `joint_matrix_load`, `joint_matrix_store`, `joint_matrix_mad`, `joint_matrix_fill`, `get_wi_data`, and the query interface, as they are defined in the sycl_ext_oneapi_matrix extension. There are exra specifics about the supported layouts for extra performance and functionality that are listed in this document. | ||||||
|
|
||||||
| ## Extra Functionality | ||||||
| ### Layout argument in `joint_matrix` type | ||||||
| Layout in `joint_matrix` type is completely optional. Intel backends do not need to know about memory layout at the moment of creation of `joint_matrix`. Therefore, `layout` in `joint_matrix` type is optional, not only for matrix `accumulator` but for also Matrix `a` and `b`. In this case, the load with layout as an argument must be used. If `layout` is specified on Matrix `a` or `b`, it must then use the load without `layout` argument. | ||||||
| The layout template argument in `joint_matrix` type is completely optional. Intel backends do not need to know about memory layout at the moment of creation of `joint_matrix`. Therefore, `layout` in `joint_matrix` type is optional, not only for matrix `accumulator` but for matrices `a` and `b` as well. In this case, the `joint_matrix_load` function that takes layout as an argument must be used. Ifthe template argument `layout` is specified on `joint_matrix` type with use `a` or `b`, it must then use the `joint_matrix_load` function that does not take `layout` as an argument. | ||||||
|
||||||
| The layout template argument in `joint_matrix` type is completely optional. Intel backends do not need to know about memory layout at the moment of creation of `joint_matrix`. Therefore, `layout` in `joint_matrix` type is optional, not only for matrix `accumulator` but for matrices `a` and `b` as well. In this case, the `joint_matrix_load` function that takes layout as an argument must be used. Ifthe template argument `layout` is specified on `joint_matrix` type with use `a` or `b`, it must then use the `joint_matrix_load` function that does not take `layout` as an argument. | |
| The layout template argument in the `joint_matrix` constructor is completely optional. Intel backends do not need to know about memory layout at the moment of creation of `joint_matrix`. Therefore, specifying `layout` in the `joint_matrix` constructor is optional, not only for matrix `accumulator` but for matrices `a` and `b` as well. In this case, the `joint_matrix_load` function that takes layout as an argument must be used. If the template argument `layout` is specified on the `joint_matrix` type with use `a` or `b`, it must then use the `joint_matrix_load` function that does not take `layout` as an argument. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.