Change the query API to match the new changes made to the matrix API #6981
Conversation
|
ping @yubingex007-a11y |
'intel_llvm/sycl' into matrix-query X
| matrix_type atype; | ||
| matrix_type btype; | ||
| matrix_type ctype; | ||
| matrix_type acuumulatortype; |
There was a problem hiding this comment.
accumulator type
| @@ -0,0 +1,143 @@ | |||
| // RUN: %clangxx -DSYCL_EXT_ONEAPI_MATRIX_VERSION=2 -fsycl -o query-use %s | |||
There was a problem hiding this comment.
do we have a testcase in llvm-test-suite and check the query result?
There was a problem hiding this comment.
@yubingex007-a11y
I am adding a test now.
BTW, https://github.com/intel/llvm/blob/sycl/sycl/include/sycl/ext/oneapi/matrix/static-query-use.hpp#L154 is currently wrong because in matrix-jit-use, we assume now that layout for A, B and C are unused.
I am correcting this now. But with adapting to the new API that is now merged (https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_oneapi_matrix/sycl_ext_oneapi_matrix.asciidoc), we need to change this back because in the new (portable) API, layout on A and B is required.
There was a problem hiding this comment.
do we have a testcase in llvm-test-suite and check the query result?
intel/llvm-test-suite#1358 adds the test
|
@againull, can you please help review/merge? |
|
@intel/llvm-reviewers-runtime, can you please help merge this? |
3 participants
#6662