-
Notifications
You must be signed in to change notification settings - Fork 801
[NFC][SYCL] Remove explicit cl:: namespace usage #6485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That is part of the change of removing cl:: entirely according to the SYCL 2020 specification.
248f425 to
e11b802
Compare
|
Please add the link to corresponding changes in llvm-test-suite here. |
It was supposed to be a standalone change. I'll investigate the failures. Edit: For some reason I thought multiple tests failed. In fact, it's only one that disables |
This PR breaks it, but it doesn't matter because next PR would remove cl:: completely.
|
/verify with intel/llvm-test-suite#1118 |
|
Ping. |
|
@intel/llvm-gatekeepers , PR is ready, I think. |
|
Nice. |
|
This one only changed the references to the symbols and is NFC. Non-NFC elimination has been done later in #6518. |
|
@aelovikov-intel I missed the big picture. Thanks for the clarification! |
That is part of the change of removing cl:: entirely according to the
SYCL 2020 specification.