Skip to content

Conversation

@aelovikov-intel
Copy link
Contributor

That is part of the change of removing cl:: entirely according to the
SYCL 2020 specification.

@aelovikov-intel aelovikov-intel requested review from a team as code owners July 27, 2022 20:01
That is part of the change of removing cl:: entirely according to the
SYCL 2020 specification.
v-klochkov
v-klochkov previously approved these changes Jul 28, 2022
@v-klochkov
Copy link
Contributor

Please add the link to corresponding changes in llvm-test-suite here.

@aelovikov-intel
Copy link
Contributor Author

aelovikov-intel commented Jul 28, 2022

Please add the link to corresponding changes in llvm-test-suite here.

It was supposed to be a standalone change. I'll investigate the failures.

Edit: For some reason I thought multiple tests failed. In fact, it's only one that disables inline in inline namespace cl {, which is an expected fail. The test is being removed in intel/llvm-test-suite#1118.

@aelovikov-intel
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1118

@aelovikov-intel
Copy link
Contributor Author

Ping.

@aelovikov-intel
Copy link
Contributor Author

@intel/llvm-gatekeepers , PR is ready, I think.

@v-klochkov v-klochkov merged commit 7cb8726 into intel:sycl Jul 29, 2022
@keryell
Copy link
Contributor

keryell commented Aug 12, 2022

Nice.
I do not think this really qualifes for [NFC].
Any program using the old non standard namespace will know fail to compile.

@aelovikov-intel
Copy link
Contributor Author

This one only changed the references to the symbols and is NFC. Non-NFC elimination has been done later in #6518.

@keryell
Copy link
Contributor

keryell commented Aug 13, 2022

@aelovikov-intel I missed the big picture. Thanks for the clarification!

@aelovikov-intel aelovikov-intel deleted the remove-implicit-cl branch August 25, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants