[SYCL][API-break] Remove "using namespace experimental" inside ext::intel #6415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntel It had been deprecated before. I don't think it's an ABI break but it is definitely an API break and we still need to increment major version in the next release.
v-klochkov
approved these changes
Jul 8, 2022
Contributor
|
Please notice the fail on OnlineCompiler/online_compiler_L0.cpp. IMO, most likely it is caused by this PR. |
Contributor
Author
|
/verify with intel/llvm-test-suite#1080 |
Contributor
Author
|
Pre-commit testing using intel/llvm-test-suite#1080 completed successfully and the llvm-test-suite fix has been merged in, This PR is ready now, @intel/llvm-gatekeepers . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It had been deprecated before. I don't think it's an ABI break but it is
definitely an API break and we still need to increment major version in the next
release.