Skip to content

[SYCL] Refactor SYCL kernel object handling in hierarchical parallelism #6212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bader merged 15 commits into from
Jun 15, 2022
Merged

[SYCL] Refactor SYCL kernel object handling in hierarchical parallelism #6212

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
eec1da1
Revert the logic committed by 16f64b8ff1f5fe44ff13de6c5d8fbd3818f81d43
bader May 26, 2022
6c60344
Update pass tests.
bader May 29, 2022
3530e1d
Improve debug infomation for LowerWGScope pass.
bader May 29, 2022
0e13ee9
Mark auto-generated kernel with work-group metadata.
bader May 29, 2022
e1511a7
Fix formatting.
bader May 29, 2022
eb6d2d7
Add TODO comment for a future improvement.
bader May 31, 2022
969b468
Revert "Mark auto-generated kernel with work-group metadata."
bader May 31, 2022
ca26f57
Add work-group scope attribute to the SYCL kernel
bader Jun 7, 2022
1a61c46
clang-format
bader Jun 7, 2022
b970a77
Set anonymous struct flag for lambda types only. Small refactoring.
bader Jun 12, 2022
3886d8d
Remove unused function parameter.
bader Jun 12, 2022
959e1aa
Apply code review suggestion.
bader Jun 13, 2022
2d987ac
Give a name to SYCL kernel object to make mangle-able static version …
bader Jun 14, 2022
fdeaab6
Apply code review comments.
bader Jun 14, 2022
0a5834b
Change getOwn to get.
bader Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions clang/lib/Sema/SemaSYCL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2773,8 +2773,7 @@ class SyclKernelBodyCreator : public SyclKernelFieldHandler {
TypeSourceInfo *TSInfo =
KernelObj->isLambda() ? KernelObj->getLambdaTypeInfo() : nullptr;
auto Type = QualType(KernelObj->getTypeForDecl(), 0);
if (KernelObj->isLambda())
Type->getAsRecordDecl()->setAnonymousStructOrUnion(true);
Type->getAsRecordDecl()->setAnonymousStructOrUnion(KernelObj->isLambda());
VarDecl *VD = VarDecl::Create(
Ctx, DC, KernelObj->getLocation(), KernelObj->getLocation(),
KernelObj->getIdentifier(), Type, TSInfo, SC_None);
Expand Down