Skip to content

[SYCL] Do not build device code for sub-devices #5240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bader merged 21 commits into from
Feb 18, 2022
Merged

[SYCL] Do not build device code for sub-devices #5240

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
cd9818b
[SYCL][NFC] Call getCacheItemPath only if cache is enabled
bader Dec 28, 2021
04e3869
[SYCL][NFC] Don't include sycl.hpp from headers
bader Dec 28, 2021
ba29bbe
[SYCL][NFC] Factor out empty kernel creation boilerplate
bader Dec 28, 2021
f5b380b
[SYCL] Do not build device code for sub-devices.
bader Dec 23, 2021
5a3587e
Apply clang-format
bader Dec 28, 2021
28b7f80
Fix issues caught by pre-commit CI.
bader Dec 29, 2021
61e09bd
[NFC] Fix a few typos in the comments
bader Dec 29, 2021
d5b93f0
Merge remote-tracking branch 'intel/sycl' into optimize-build
bader Jan 20, 2022
a1e483a
Improved build results caching for GPU devices.
bader Jan 21, 2022
7ac48ae
Improve GPU caching.
bader Jan 24, 2022
d0f2861
Revert "Improve GPU caching."
bader Feb 8, 2022
231a1a3
Revert "Improved build results caching for GPU devices."
bader Feb 8, 2022
8f2d9c4
Merge remote-tracking branch 'intel/sycl' into optimize-build
bader Feb 8, 2022
d44e27f
Fix formatting.
bader Feb 8, 2022
6e310b0
Add device query for checking if device architecture is homogeneous
bader Feb 14, 2022
ce299cd
Merge remote-tracking branch 'intel/sycl' into optimize-build
bader Feb 14, 2022
e6ca4f9
Address code review feedback
bader Feb 15, 2022
bf57926
Added a FIXME comment.
bader Feb 17, 2022
d062d77
Merge remote-tracking branch 'intel/sycl' into optimize-build
bader Feb 17, 2022
0e650ea
Update sycl/source/detail/program_manager/program_manager.cpp
bader Feb 17, 2022
d1cc7aa
Move comment to Level Zero plug-in.
bader Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions sycl/source/detail/persistent_device_code_cache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,13 @@ void PersistentDeviceCodeCache::putItemToDisc(
const SerializedObj &SpecConsts, const std::string &BuildOptionsString,
const RT::PiProgram &NativePrg) {

if (!isImageCached(Img))
return;

std::string DirName =
getCacheItemPath(Device, Img, SpecConsts, BuildOptionsString);

if (!isImageCached(Img) || DirName.empty())
if (DirName.empty())
return;

auto Plugin = detail::getSyclObjImpl(Device)->getPlugin();
Expand Down Expand Up @@ -137,10 +140,13 @@ std::vector<std::vector<char>> PersistentDeviceCodeCache::getItemFromDisc(
const device &Device, const RTDeviceBinaryImage &Img,
const SerializedObj &SpecConsts, const std::string &BuildOptionsString) {

if (!isImageCached(Img))
return {};

std::string Path =
getCacheItemPath(Device, Img, SpecConsts, BuildOptionsString);

if (!isImageCached(Img) || Path.empty() || !OSUtil::isPathPresent(Path))
if (Path.empty() || !OSUtil::isPathPresent(Path))
return {};

int i = 0;
Expand Down