[SYCL] Error out instead of crash when templated global var used #5195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SYCL deferred diagnostics couldn't catch the case like:
```
template <typename T>
class randomType {
public:
randomType() {}
T val;
};
template <typename T>
const randomType<T> Var;
SYCL_EXTERNAL void foo() {
(void)Var<int>;
}
```
And CodeGen was crashing due to attempt to emit invalid cast.
That happened because use of `Var` should be diagnosed. The diagnostic
wasn't emitted because at the places where deferred diagnostic is issued
for this case, templated variable doesn't yet has initializer, or it has
it but current lexical context is out of device code (in this particular
case it will be a translation unit). This patch follows the logic
invented by `finalizeOpenMPDelayedAnalysis` and `finalizeSYCLDelayedAnalysis`
routines, i.e. emit immediate diagnostic when post-parsing of AST for
deferred diagnostics happens.
Fznamznon
requested review from
elizabethandrews,
premanandrao and
smanna12
as code owners
smanna12
reviewed
Dec 21, 2021
smanna12
reviewed
Dec 21, 2021
elizabethandrews
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SYCL deferred diagnostics couldn't catch the case like:
And CodeGen was crashing due to attempt to emit invalid cast.
That happened because use of
Varshould be diagnosed. The diagnosticwasn't emitted because at the places where deferred diagnostic is issued
for this case, templated variable doesn't yet has initializer, or it has
it but current lexical context is out of device code (in this particular
case it will be a translation unit). This patch follows the logic
invented by
finalizeOpenMPDelayedAnalysisandfinalizeSYCLDelayedAnalysisroutines, i.e. emit immediate diagnostic when post-parsing of AST for
deferred diagnostics happens.