Skip to content

[SYCL] Release specialization constant buffer #5167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bader merged 11 commits into from
Dec 23, 2021
Merged

[SYCL] Release specialization constant buffer #5167

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a17c822
draft releasing spec const buffer
HabKaffee Dec 17, 2021
e372859
add SpecConstBuffer.cpp
HabKaffee Dec 17, 2021
13a2ce7
Revert debug changings
HabKaffee Dec 17, 2021
b1ef076
Merge remote-tracking branch 'upstream/sycl' into releasing_spec_cons…
HabKaffee Dec 17, 2021
a41683f
Revert some debug changes
HabKaffee Dec 17, 2021
5565569
Added MSpecConstAccessMtx and some minor changes
HabKaffee Dec 22, 2021
bcac087
Clang fix
HabKaffee Dec 22, 2021
2d76e4b
Merge branch 'intel:sycl' into releasing_spec_const_buffer
HabKaffee Dec 22, 2021
f044d53
Merge branch 'intel:sycl' into releasing_spec_const_buffer
HabKaffee Dec 23, 2021
c33085c
apply suggested changes
HabKaffee Dec 23, 2021
2e4e320
Merge branch 'releasing_spec_const_buffer' of https://github.com/HabK…
HabKaffee Dec 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sycl/source/detail/device_image_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,10 @@ class device_image_impl {
const detail::plugin &Plugin = getSyclObjImpl(MContext)->getPlugin();
Plugin.call<PiApiKind::piProgramRelease>(MProgram);
}
if (MSpecConstsBuffer) {
const detail::plugin &Plugin = getSyclObjImpl(MContext)->getPlugin();
Plugin.call<PiApiKind::piMemRelease>(MSpecConstsBuffer);
}
}

private:
Expand Down
1 change: 0 additions & 1 deletion sycl/source/detail/program_manager/program_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1330,7 +1330,6 @@ static bool compatibleWithDevice(RTDeviceBinaryImage *BinImage,

kernel_id ProgramManager::getSYCLKernelID(const std::string &KernelName) {
std::lock_guard<std::mutex> KernelIDsGuard(m_KernelIDsMutex);

auto KernelID = m_KernelIDs.find(KernelName);
if (KernelID == m_KernelIDs.end())
throw runtime_error("No kernel found with the specified name",
Expand Down
1 change: 0 additions & 1 deletion sycl/source/handler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,6 @@ void handler::verifyUsedKernelBundle(const std::string &KernelName) {
getOrInsertHandlerKernelBundle(/*Insert=*/false);
if (!UsedKernelBundleImplPtr)
return;

kernel_id KernelID = detail::get_kernel_id_impl(KernelName);
device Dev = detail::getDeviceFromHandler(*this);
if (!UsedKernelBundleImplPtr->has_kernel(KernelID, Dev))
Expand Down
1 change: 0 additions & 1 deletion sycl/unittests/SYCL2020/SpecializationConstant.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ TEST(SpecializationConstant, DefaultValuesAreSet) {

sycl::unittest::PiMock Mock{Plt};
setupDefaultMockAPIs(Mock);

const sycl::device Dev = Plt.get_devices()[0];

sycl::queue Queue{Dev};
Expand Down