[SYCL] Remove unnecessary template parameter #5127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbatashev
changed the title
cperkinsintel
approved these changes
Dec 13, 2021
Contributor
cperkinsintel
left a comment
cperkinsintel
left a comment
There was a problem hiding this comment.
this looks good to me.
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Dec 14, 2021
* sycl: [CI] Refactor workflow files (intel#5134) [CI] Enable HIP and CUDA plugins in GitHub Actions builds (intel#5087) [SYCL] Implement queue flushing (intel#5052) [SYCL] Allow library mismatch for libdevice host object on Win32 (intel#5048) [SYCL] Remove unnecessary template parameter (intel#5127) [CI] Use clang-format from nightly builds (intel#5126)
psalz
added a commit
to KhronosGroup/SYCL-CTS
that referenced
this pull request
Dec 27, 2021
This includes two changes that should improve CTS compilation times (intel/llvm#5127, intel/llvm#5178).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing unnecessary KernelName parameter with a bool value that is actually used in
HostKernelclass reduces the number of instantiated templates and may improve host-side frontend time by ~9%.