Skip to content

[SYCL] piextQueueCreateWithNativeHandle should not be followed by a piQueueRetain #4988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romanovvlad merged 5 commits into from
Dec 1, 2021
Merged

[SYCL] piextQueueCreateWithNativeHandle should not be followed by a piQueueRetain #4988

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3690165
[SYCL] piextQueueCreateWithNativeHandle should not be followed by a p…
smaslov-intel Nov 18, 2021
8055c91
fix build
smaslov-intel Nov 18, 2021
8f0b9b6
[SYCL] Add unittest
smaslov-intel Nov 23, 2021
b3397bf
clang-format
smaslov-intel Nov 23, 2021
e95ced8
address review comments
smaslov-intel Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sycl/plugins/opencl/pi_opencl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,7 @@ pi_result piextQueueCreateWithNativeHandle(pi_native_handle nativeHandle,
(void)ownNativeHandle;
assert(piQueue != nullptr);
*piQueue = reinterpret_cast<pi_queue>(nativeHandle);
clRetainCommandQueue(cast<cl_command_queue>(nativeHandle));
return PI_SUCCESS;
}

Expand Down
3 changes: 0 additions & 3 deletions sycl/source/detail/queue_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,6 @@ class queue_impl {
sizeof(Device), &Device, nullptr);
MDevice =
DeviceImplPtr(new device_impl(Device, Context->getPlatformImpl()));

// TODO catch an exception and put it to list of asynchronous exceptions
getPlugin().call<PiApiKind::piQueueRetain>(MQueues[0]);
}

~queue_impl() {
Expand Down