Skip to content

[SYCL] Fix overwriting insert to sub_group_mask #4656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vladimirlaz merged 1 commit into from
Sep 29, 2021
Merged

[SYCL] Fix overwriting insert to sub_group_mask #4656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/include/sycl/ext/oneapi/sub_group_mask.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ struct sub_group_mask {
uint32_t mask = 0;
if (pos.get(0) + insert_size < size())
mask |= (0xffffffff << (pos.get(0) + insert_size));
if (pos.get(0) < size())
if (pos.get(0) < size() && pos.get(0))
mask |= (0xffffffff >> (size() - pos.get(0)));
Bits &= mask;
Bits += insert_data;
Expand Down
22 changes: 22 additions & 0 deletions sycl/test/extensions/sub_group_mask.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,26 @@ int main() {
sycl::marray<char, 6> r3{-1};
b.extract_bits(r3, 14);
assert(r3[0] == 1 && r3[1] == 2 && r3[2] == 2 && !r3[3] && !r3[4] && !r3[5]);
int ibits = 0b1010101010101010101010101010101;
b.insert_bits(ibits);
for (size_t i = 0; i < 32; i++) {
assert(b[i] != (bool)(i % 2));
}
short sbits = 0b0111011101110111;
b.insert_bits(sbits, 7);
b.extract_bits(ibits);
assert(ibits == 0b1010101001110111011101111010101);
sbits = 0b1100001111000011;
b.insert_bits(sbits, 23);
b.extract_bits(ibits);
assert(ibits == 0b11100001101110111011101111010101);
int64_t lbits = -1;
b.extract_bits(lbits, 33);
assert(lbits == 0);
lbits = -1;
b.extract_bits(lbits, 5);
assert(lbits == 0b111000011011101110111011110);
lbits = -1;
b.insert_bits(lbits);
assert(b.all());
}