Skip to content

[SYCL] Fix bit_cast for half type #4603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dm-vodopyanov merged 8 commits into from
Sep 23, 2021
Merged

[SYCL] Fix bit_cast for half type #4603

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6579b3a
Fix bit_cast for half type
maximdimakov Sep 20, 2021
8816111
Clang-format fix
maximdimakov Sep 20, 2021
9b9ca33
Refactoring of helpers
maximdimakov Sep 21, 2021
b4d532a
Clang-format fix
maximdimakov Sep 21, 2021
626da4a
Add regression test
maximdimakov Sep 22, 2021
81d9caa
Fix run line
maximdimakov Sep 22, 2021
0cc3974
Separate win and lin tests for bit_cast
maximdimakov Sep 22, 2021
90dc128
Fix run line for windows
maximdimakov Sep 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion sycl/include/CL/sycl/bit_cast.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

#pragma once

#include <CL/sycl/aliases.hpp>

#include <type_traits>

#if __cpp_lib_bit_cast
Expand All @@ -20,6 +22,10 @@ namespace sycl {
// forward decl
namespace detail {
inline void memcpy(void *Dst, const void *Src, std::size_t Size);

template <typename Type> struct type_helper { using T = Type; };

template <> struct type_helper<sycl::half> { using T = uint16_t; };
}

template <typename To, typename From>
Expand All @@ -41,7 +47,8 @@ constexpr
#if __has_builtin(__builtin_bit_cast)
return __builtin_bit_cast(To, from);
#else // __has_builtin(__builtin_bit_cast)
static_assert(std::is_trivially_default_constructible<To>::value,
static_assert(std::is_trivially_default_constructible<
typename detail::type_helper<To>::T>::value,
"To must be trivially default constructible");
To to;
sycl::detail::memcpy(&to, &from, sizeof(To));
Expand Down