[SYCL] target enumeration SYCL 2020 update: deprecate global_buffer #4588
+126
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ork required to realize full SYCL 2020 changes to target values. Signed-off-by: Chris Perkins <[email protected]>
…opriate. Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
cperkinsintel
changed the title
Signed-off-by: Chris Perkins <[email protected]>
cperkinsintel
requested review from
a team,
DenisBakhvalov,
kbobrovs and
kychendev
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SYCL 2020 spec deprecates four of the enumeration values and replaces them with two new ones. While mostly a fairly straightforward change, I realize this is beginning to touch a lot of code, which will make it difficult to review. So I'm breaking it into smaller chunks.
We've already added device::target in a previous PR. In this PR we are simply marking target::global_buffer as deprecated and updating its uses in the code base.