[SYCL] Remove ONEAPI/INTEL namespaces #4488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mdimakov <[email protected]>
maximdimakov
requested review from
a team,
AlexeySachkov,
DenisBakhvalov,
MrSidims,
Pennycook,
kbobrovs and
kychendev
as code owners
maximdimakov
requested review from
AaronBallman,
elizabethandrews and
premanandrao
as code owners
AaronBallman
previously approved these changes
Sep 7, 2021
Contributor
AaronBallman
left a comment
AaronBallman
left a comment
There was a problem hiding this comment.
FE bits look good to me, but there should be a release note about the removal.
maximdimakov
dismissed stale reviews from kbobrovs and AaronBallman
via
e467164
Contributor
Author
|
Jenkins/precommit is failing due to old versions of oneDPL headers. There is a permission from oneDPL team to merge this patch with failing tests. |
alexbatashev
approved these changes
Sep 25, 2021
romanovvlad
approved these changes
Sep 27, 2021
Contributor
Author
|
@AaronBallman, @kbobrovs could you, please, approve? |
AaronBallman
approved these changes
Sep 27, 2021
Contributor
AaronBallman
left a comment
AaronBallman
left a comment
There was a problem hiding this comment.
LGTM, but with a reminder about the release note request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ONEAPI/INTEL namespaces are deprecated in SYCL 2020
This patch depends on tests : intel/llvm-test-suite#442