[SYCL] Restore the correct initialization for _statically_coalesce_val #4206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch intel#3957 introduces `_statically_coalesce_val` in fpga_lsu.cpp like this: ``` _GetValue<statically_coalesce_impl<1>, _mem_access_params...>::value; ``` During merge conflict resolution in intel#4014 it was change accidentally to ``` _GetValue<statically_coalesce_impl<0>, _mem_access_params...>::value; ``` Restoring the right value.
Contributor
Author
|
@v-klochkov is on vacation, @intel/llvm-reviewers-runtime, can someone review? |
zahiraam
pushed a commit
to zahiraam/llvm-1
that referenced
this pull request
Aug 2, 2021
intel#4206) Patch intel#3957 introduces `_statically_coalesce_val` in fpga_lsu.cpp like this: ``` _GetValue<statically_coalesce_impl<1>, _mem_access_params...>::value; ``` During merge conflict resolution in intel#4014 it was change accidentally to ``` _GetValue<statically_coalesce_impl<0>, _mem_access_params...>::value; ``` Restoring the right value.
dm-vodopyanov
deleted the
private/dvodopya/restore-right-_statically_coalesce_val-initialization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch #3957 introduces
_statically_coalesce_valin fpga_lsu.cpp like this:During merge conflict resolution in #4014 it was change accidentally to
Restoring the right value.