Skip to content

[SYCL][ROCm] Fix compilation for AMD GPU with -fsycl-dead-args-optimization #4126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bader merged 3 commits into from
Jul 20, 2021
Merged

[SYCL][ROCm] Fix compilation for AMD GPU with -fsycl-dead-args-optimization #4126

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f013614
-emit-param-info is not added with AMD and -fscyl-dead-args
Jul 16, 2021
7c59e74
clang-format
Jul 16, 2021
3947ec0
Added test for dae flags
Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion clang/lib/Driver/ToolChains/Clang.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8856,7 +8856,8 @@ void SYCLPostLink::ConstructJob(Compilation &C, const JobAction &JA,
// -fsycl-device-code-split=auto

// Turn on Dead Parameter Elimination Optimization with early optimizations
if (!getToolChain().getTriple().isNVPTX() &&
if (!(getToolChain().getTriple().isNVPTX() ||
getToolChain().getTriple().isAMDGCN()) &&
TCArgs.hasFlag(options::OPT_fsycl_dead_args_optimization,
options::OPT_fno_sycl_dead_args_optimization, false))
addArgs(CmdArgs, TCArgs, {"-emit-param-info"});
Expand Down