[sycl-post-link] Fix call graph traversal for assert property generation #3998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmaksimo
requested review from
AlexeySachkov,
kbobrovs and
mlychkov
as code owners
This patch fixes early exit on call graph traversal. Now we do not mark all functions above as "definitely does not call assert" as we can be sure it's true only for a reached leaf.
vmaksimo
force-pushed
the
fix_assert_property
branch
from
33399ad to
fcc53ea
Compare
mlychkov
previously approved these changes
Jun 25, 2021
AlexeySachkov
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes early exit on call graph traversal. Now we do not mark
all functions above as "definitely does not call assert" as we can be sure it's
true only for a reached leaf.