Skip to content

[SYCL][CUDA] atomic_ref.fetch_add used for fp64 reduction if device.has(atomic64) #3950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bader merged 11 commits into from
Jun 30, 2021
Merged

[SYCL][CUDA] atomic_ref.fetch_add used for fp64 reduction if device.has(atomic64) #3950

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f95f28c
[SYCL][CUDA] atomic_ref.fetch_add used for fp64 (add operator) reduct…
Jun 17, 2021
80c8508
cl_khr_fp64 and cl_khr_fp16 extensions are now connected to the cuda …
Jun 23, 2021
b1a8a7d
Revert "cl_khr_fp64 and cl_khr_fp16 extensions are now connected to t…
Jun 23, 2021
70a2c54
The cl_khr_fp64 extension is now connected to the cuda plugin.
Jun 23, 2021
ab8a600
Renamed has_atomic_add_float to has_atomic_add_float64.
Jun 24, 2021
49ec72a
PI_DEVICE_INFO_ATOMIC_64 is now checked for all backends when get_inf…
Jun 28, 2021
3b4bc5b
Merge branch 'sycl' into reduction_atomic64_add
JackAKirk Jun 28, 2021
b4bde0c
Removed unnecessary screen print out.
Jun 29, 2021
6a0f948
Return false if Err == PI_INVALID_VALUE.
Jun 29, 2021
24ee26e
Swapped (Err == PI_INVALID_VALUE) with (Err != PI_SUCCESS).
Jun 29, 2021
471ccde
Apply suggestions from code review
bader Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions sycl/source/detail/device_info.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,15 +240,9 @@ template <> struct get_device_info<bool, info::device::atomic64> {

bool result = false;

RT::PiResult Err = Plugin.call_nocheck<PiApiKind::piDeviceGetInfo>(
Plugin.call_nocheck<PiApiKind::piDeviceGetInfo>(
Comment thread
bader marked this conversation as resolved.
Outdated
dev, pi::cast<RT::PiDeviceInfo>(info::device::atomic64), sizeof(result),
&result, nullptr);
if (Err == PI_INVALID_VALUE) {
std::cout
<< "The Plugin Interface has returned an error:\n The value of "
"the atomic64 device aspect is unknown, Setting atomic64 "
"= false.\n\n";
}

return result;
}
Expand Down