Skip to content

{SYCL][PI][L0] - Eliminate std::string construction/destruction overh… #3931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvchupin merged 1 commit into from
Jun 16, 2021
Merged

{SYCL][PI][L0] - Eliminate std::string construction/destruction overh… #3931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions sycl/plugins/level_zero/pi_level_zero.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ class ZeCall {
}

// The non-static version just calls static one.
ze_result_t doCall(ze_result_t ZeResult, std::string ZeName,
std::string ZeArgs, bool TraceError = true);
ze_result_t doCall(ze_result_t ZeResult, const char *ZeName,
const char *ZeArgs, bool TraceError = true);
};
std::mutex ZeCall::GlobalLock;

Expand Down Expand Up @@ -408,7 +408,7 @@ static pi_result enqueueMemCopyRectHelper(
const pi_event *EventWaitList, pi_event *Event,
bool PreferCopyEngine = false);

inline void zeParseError(ze_result_t ZeError, std::string &ErrorString) {
inline void zeParseError(ze_result_t ZeError, const char *&ErrorString) {
switch (ZeError) {
#define ZE_ERRCASE(ERR) \
case ERR: \
Expand Down Expand Up @@ -456,18 +456,18 @@ inline void zeParseError(ze_result_t ZeError, std::string &ErrorString) {
} // switch
}

ze_result_t ZeCall::doCall(ze_result_t ZeResult, std::string ZeName,
std::string ZeArgs, bool TraceError) {
zePrint("ZE ---> %s%s\n", ZeName.c_str(), ZeArgs.c_str());
ze_result_t ZeCall::doCall(ze_result_t ZeResult, const char *ZeName,
const char *ZeArgs, bool TraceError) {
zePrint("ZE ---> %s%s\n", ZeName, ZeArgs);

if (ZeDebug & ZE_DEBUG_CALL_COUNT) {
++(*ZeCallCount)[ZeName];
}

if (ZeResult && TraceError) {
std::string ErrorString;
const char *ErrorString = "Unknown";
zeParseError(ZeResult, ErrorString);
zePrint("Error (%s) in %s\n", ErrorString.c_str(), ZeName.c_str());
zePrint("Error (%s) in %s\n", ErrorString, ZeName);
}
return ZeResult;
}
Expand Down