Skip to content

[SYCL] Fix unused variable warning detected by post-commit tests #3884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bader merged 3 commits into from
Jun 4, 2021
Merged

[SYCL] Fix unused variable warning detected by post-commit tests #3884

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e26f8f7
Fix post-commit after PR #3826
dm-vodopyanov Jun 4, 2021
f43acb4
Apply CR comment
dm-vodopyanov Jun 4, 2021
2367716
Add missing include
bader Jun 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions sycl/source/detail/allowlist.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
#include <detail/device_impl.hpp>
#include <detail/platform_info.hpp>

#include <algorithm>
#include <regex>

__SYCL_INLINE_NAMESPACE(cl) {
Expand Down Expand Up @@ -239,10 +240,14 @@ AllowListParsedT parseAllowList(const std::string &AllowListRaw) {
// Checking if we can allow device with device description DeviceDesc
bool deviceIsAllowed(const DeviceDescT &DeviceDesc,
const AllowListParsedT &AllowListParsed) {
for (const auto &SupportedKeyName : SupportedAllowListKeyNames)
assert((DeviceDesc.find(SupportedKeyName) != DeviceDesc.end()) &&
"DeviceDesc map should have all supported keys for "
"SYCL_DEVICE_ALLOWLIST.");
assert(std::all_of(SupportedAllowListKeyNames.begin(),
SupportedAllowListKeyNames.end(),
[&DeviceDesc](const auto &SupportedKeyName) {
return DeviceDesc.find(SupportedKeyName) !=
DeviceDesc.end();
}) &&
"DeviceDesc map should have all supported keys for "
"SYCL_DEVICE_ALLOWLIST.");
auto EqualityComp = [&](const std::string &KeyName,
const DeviceDescT &AllowListDeviceDesc) {
// change to map::contains after switching DPC++ RT to C++20
Expand Down