[SYCL][ESIMD] Make typenames and constants consistent with SYCL API style. #3850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tyle. Also add some doc comments and a test, improve existing tests. Signed-off-by: kbobrovs <[email protected]>
Contributor
DenisBakhvalov
left a comment
DenisBakhvalov
left a comment
There was a problem hiding this comment.
API changes LGTM.
| } | ||
|
|
||
| namespace detail { | ||
| static inline constexpr atomic_op convert(EsimdAtomicOpType Op) { |
Contributor
There was a problem hiding this comment.
I can't find where this code is used.
Contributor
Author
There was a problem hiding this comment.
right, remnant from previous version - will clean-up.
| #define __ESIMD_QUOTE1(m) #m | ||
| #define __ESIMD_QUOTE(m) __ESIMD_QUOTE1(m) | ||
| #define __ESIMD_NS_QUOTED __ESIMD_QUOTE(__ESIMD_NS) | ||
| #define __ESIMD_DEPRECATED(new_api) \ |
Contributor
There was a problem hiding this comment.
nit: should we undef those defines as well.
Contributor
Author
There was a problem hiding this comment.
I think those can be useful in other headers.
__ESIMD_NS should actually replace __SEIEE according to prior reviews.
kbobrovs
commented
Jun 2, 2021
DenisBakhvalov
approved these changes
Jun 2, 2021
rolandschulz
approved these changes
Jun 2, 2021
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Jun 4, 2021
* sycl: (320 commits) [SYCL] Silence a "local variable is initialized but not referenced" warning; NFC (intel#3870) [SYCL] Improve SYCL_DEVICE_ALLOWLIST (intel#3826) [SPIR-V] Change return value of mapType function (intel#3871) [SYCL] Fix post-commit failure in handler.hpp from unused-parameters. (intel#3874) [Driver][SYCL] Do not imply defaultlib msvcrt for Linux based driver on Windows (intel#3827) [SYCL] Unique stable name rebase (intel#3835) [SYCL] Align behavior of empty command groups with SYCL2020 (intel#3822) [SYCL][ESIMD] Make typenames and constants consistent with SYCL API style. (intel#3850) [SYCL] Allow __failed_assertion to support libstdc++-11 (intel#3774) [SYCL] Refactor stream class handing implementation (intel#3646) [SYCL] Fix syntax error introduced in intel#3401 (intel#3861) [SYCL] SYCL 2020 sub_group algorithms (intel#3786) [Buildbot][NFC] Add option to use LLD as linker (intel#3866) Revert "Emit correct location lists with basic block sections." [SPIRITTAnnotations] Fix debug info for ITT calls. (intel#3829) [SYCL][Doc] Fix build of Sphinx docs (intel#3863) [SYCL][FPGA][NFC] Tidy up intel_fpga_reg codegen test (intel#3810) [CODEOWNERS] Fix SPIRITTAnnnotations tests ownership (intel#3859) [SYCL][ESIMD] Host-compile simd.cpp test, fix errors & warnings. (intel#3846) [SYCL] Store pointers to memory allocations instead of iterators (intel#3860) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add some doc comments and a test, improve existing tests.
Main changes:
GENX_NOSAT/GENX_SATwithenum class saturationenum ChannelMaskTypewithenum class rgba_channel_maskenum class rgba_channelEsimdAtomicOpTypewithenum class atomic_opEsimdSbarrierTypewithenum class split_barrier_actionAll existing types remain, but deprecated.
Signed-off-by: kbobrovs [email protected]