[SYCL]Fixes a performance issue due to https://github.com/intel/llvm/… #3797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change does two things to fix the performance issue. The first is in the level zero plugin. Here the change is to only close and submit the batch if the event being queried is one that will be signalled one of the commands in the batch. The second change is in the sycl run-time itself. This change prevents the event cleanup code from querying every single event that is outstanding in the system. This is necessary to prevent the most recent events (which are likely to be in the plug-ins batch) from being queried. Both changes are required to fix the performance issue.
romanovvlad
requested changes
May 21, 2021
Contributor
romanovvlad
left a comment
romanovvlad
left a comment
There was a problem hiding this comment.
Could you please add a test/extend existing one?
Example of a test for sycl::queue:
sycl/source see unittests/queue/EventClear.cpp
Contributor
Author
Done. Updated unittests/queue/EventClear.cpp |
romanovvlad
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pull/3612
This change does two things to fix the performance issue.
The first is in the level zero plugin. Here the change is to only
close and submit the batch if the event being queried is one that
will be signalled one of the commands in the batch.
The second change is in the sycl run-time itself. This change
prevents the event cleanup code from querying every single event
that is outstanding in the system. This is necessary to prevent
the most recent events (which are likely to be in the plug-ins batch)
from being queried.
Both changes are required to fix the performance issue.