[SYCL] Add DPC++ RT support for SYCL2020 spec constants' default values#3667
Merged
romanovvlad merged 9 commits intoMay 12, 2021
Merged
Conversation
This patch introduces the support of default values for SYCL2020 specialization constants in DPC++ runtime.
romanovvlad
reviewed
May 4, 2021
added 2 commits
May 7, 2021 12:44
added 2 commits
May 7, 2021 14:49
Contributor
|
@intel/llvm-reviewers-runtime friendly ping |
dm-vodopyanov
commented
May 11, 2021
Co-authored-by: Dmitry Vodopyanov <dmitryvodop@gmail.com>
dm-vodopyanov
commented
May 11, 2021
dm-vodopyanov
left a comment
dm-vodopyanov
left a comment
Contributor
Author
There was a problem hiding this comment.
LGTM, but being the submitter of the PR, I can't press the approve button.
Contributor
Author
|
Failures in Jenkins/Precommit are not related to this patch and look flaky, created trackers and re-started the job:
|
Contributor
It should be
|
Contributor
|
@smaslov-intel friendly ping |
romanovvlad
reviewed
May 12, 2021
smaslov-intel
approved these changes
May 12, 2021
dm-vodopyanov
deleted the
private/dvodopya/spec-const-w-default-values
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces the support of default values for SYCL2020
specialization constants in DPC++ runtime.