Revert "Copy attributes of parallel_for kernels to the wrapped versions when rounding up the range" #3293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
requested review from
a team,
elizabethandrews and
premanandrao
as code owners
elizabethandrews
approved these changes
Mar 3, 2021
Contributor
elizabethandrews
left a comment
elizabethandrews
left a comment
There was a problem hiding this comment.
@bader is this patch being reverted because of SemaSYCL/num_simd_work_items_device.cpp test failure?
Contributor
Author
Yes. |
alexbatashev
approved these changes
Mar 3, 2021
jsji
pushed a commit
that referenced
this pull request
Sep 6, 2025
For e.g. a `foo(image2d_t %img)` function type, clang produces
@foo(target("spirv.Image", void, 1, 0, 0, 0, 0, 0, 0) %img)
but after OpenCL -> SPIR-V translation, the SPIR-V reader would
translate it into
@foo(ptr addrspace(1) %img)
Preserve image argument types as `TargetExtType`s when translating to an
OpenCL target environment. `TargetExtType`s are already emitted for
SPIR-V friendly IR.
Make sure not to mangle the `TargetExtType` argument in the usual way,
but continue using the special type mangling emitted by clang (e.g.
`ocl_image1d_rw`).
Contributes to
KhronosGroup/SPIRV-LLVM-Translator#3287
Original commit:
KhronosGroup/SPIRV-LLVM-Translator@2feb3e3eafc4855
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3154