Skip to content

Conversation

@DenisBakhvalov
Copy link
Contributor

@DenisBakhvalov DenisBakhvalov commented Jan 21, 2021

This change is a part of 3 patches:
Patch (1/3): [new property] #3072
Patch (2/3): [sycl-post-link] #3073
Patch (3/3): [DPCPP RT] this PR

Please review only patch f8fdd3c

smaslov-intel
smaslov-intel previously approved these changes Jan 22, 2021
Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. NOTE: the pi changes are already a part of #3072

@DenisBakhvalov
Copy link
Contributor Author

DenisBakhvalov commented Jan 23, 2021

NOTE: The current PR will not have any immediate impact on functionality since we guard splitting SYCL and ESIMD code in sycl-post-link tool under an option (-split-esimd). This PR will make it a default: #3086.

@kbobrovs, @romanovvlad, @bader, My current plan is to test it using SYCL_PI_TRACE output. I.e. put the functional test in the llvm-test-suite (see intel/llvm-test-suite#110). Is it OK for this patch (f8fdd3c) to go without the immediate test? Eventually, every SYCL/ESIMD test will be "de facto" testing this code.

@romanovvlad
Copy link
Contributor

NOTE: The current PR will not have any immediate impact on functionality since we guard splitting SYCL and ESIMD code in sycl-post-link tool under an option (-split-esimd). This PR will make it a default: #3086.

@kbobrovs, @romanovvlad, @bader, My current plan is to test it using SYCL_PI_TRACE output. I.e. put the functional test in the llvm-test-suite (see intel/llvm-test-suite#110). Is it OK for this patch (f8fdd3c) to go without the immediate test? Eventually, every SYCL/ESIMD test will be "de facto" testing this code.

OK with me.

romanovvlad
romanovvlad previously approved these changes Jan 25, 2021
Copy link
Contributor

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. but the identifier might change if we rename SYCL/Is ESIMD Image category change.

@DenisBakhvalov
Copy link
Contributor Author

Closing this PR since there were significant changes to #3072 (the PR that precedes this). I will submit a new PR once #3072 will get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants