Skip to content

Conversation

@cmc-rep
Copy link
Contributor

@cmc-rep cmc-rep commented Jan 13, 2021

Signed-off-by: Gang Y Chen [email protected]

@cmc-rep cmc-rep requested a review from kbobrovs as a code owner January 13, 2021 16:25
@cmc-rep cmc-rep requested a review from kychendev January 13, 2021 16:41
@cmc-rep
Copy link
Contributor Author

cmc-rep commented Jan 13, 2021

@kbobrovs, a test failed. However, after looking into the detail, the failure seems not relevant to esimd. What should I do in this case?

@cmc-rep
Copy link
Contributor Author

cmc-rep commented Jan 13, 2021

@vladimirlaz, jenkins test failed. However, looking at the error details, I don't think it is related to this PR. How can we resolve this?

@kbobrovs
Copy link
Contributor

Looks like infrastructure failure. I restarted the build. I think every PR submitter should be able to do this - click 'details' for the web page where rebuild can be started

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a testcase for %=

are you going to create executable tests for new esimd functionality you add?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test added. Yes, I will modify some existing examples to use the new esimd functionality.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kychendev @kbobrovs please review and merge timely

@kbobrovs kbobrovs merged commit d43b92a into intel:sycl Jan 14, 2021
@cmc-rep cmc-rep deleted the cmc-rep-change branch January 15, 2021 01:03
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Jan 19, 2021
* sycl: (378 commits)
  [sycl-post-link][NFC] Extracted the code into a subroutine (intel#3042)
  [SYCL][NFC] Remove commented out code (intel#3029)
  [CODEOWNERS] Fix ownership of DPC++ tools tests (intel#3047)
  [SYCL][NFC] Make tests insensitive to dso_local (intel#3037)
  [SYCL] Fix acquiring a mutex in _pi_context::finalize (intel#3001)
  [SYCL] Fix various compilation warnings in plugins (intel#2979)
  [SYCL][ESIMD] Add simd class conversion ctor and operator (intel#3028)
  [sycl-post-link][NFC] Use range-based for loop. (intel#3033)
  [SYCL][NFC] Fix warning in self-build (intel#3023)
  [NFC] Fix sycl-post-link tests to avoid potential race (intel#3031)
  [SYCL][CUDA] Add missing barrier to collectives (intel#2990)
  [SYCL] Make Intel attributes consistent with clang attributes. (intel#3022)
  [SYCL] Bump SYCL minor version (intel#3026)
  [SYCL][Doc] Added requirement on reference to test PR in commit message (intel#3010)
  [SYCL] Put constant initializer list data in non-generic addr space. (intel#3005)
  [SYCL][L0] Fix memory leak in PiDeviceCache and ZeCommandList (intel#2974)
  [SYCL] Fix detection of free function calls (intel#3003)
  [SYCL][NFC] Clean up the builder_dir argument description (intel#3021)
  [SYCL][ESIMD] Fix LowerESIMD crash on a scalar fptoui LLVM instruction (intel#2699)
  [NFC] Remove redundant call to getMainExecutable() (intel#3018)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants