[NFC][SYCL] Use visitor to emit forward declarations #2670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fznamznon
requested review from
elizabethandrews and
premanandrao
as code owners
Contributor
Author
|
LIT failures are expected, since this patch depends on #2644 . |
erichkeane
reviewed
Oct 22, 2020
srividya-sundaram
previously approved these changes
Oct 22, 2020
Contributor
srividya-sundaram
left a comment
srividya-sundaram
left a comment
There was a problem hiding this comment.
I will try to get the blocking patch in by early next week. Thanks!
Contributor
Author
Thanks! |
erichkeane
approved these changes
Oct 22, 2020
Contributor
Author
|
This one should be ready now. |
jsji
pushed a commit
that referenced
this pull request
Sep 8, 2024
…ng (#2677) This PR adds "reverse translation" (from SPIR-V to LLVM IR) support for OpDecorateString and OpMemberDecorateString, see #2460 and #2670. These instructions are currently treated as synonyms for OpDecorate and OpMemberDecorate. We'll want to tidy this up at some point, but at least for now we won't crash if we see these instructions. I'll still need to add proper support for decorating variables in the input storage class for #2670, but I'll do that in a separate PR. Original commit: KhronosGroup/SPIRV-LLVM-Translator@f7057b44e20fd06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.