Skip to content

[SYCL] Added error handling for non-uniform work group size case #2569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bader merged 6 commits into from
Oct 2, 2020
Merged

[SYCL] Added error handling for non-uniform work group size case #2569

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ff51f17
[SYCL] Added error handling for non-uniform work group size case
etdamiba-intel Sep 29, 2020
1ff860a
[SYCL] Added explicit error message for non uniform group size error.
etdamiba-intel Sep 30, 2020
4e8f0e0
Incorporating code review comments
etdamiba-intel Sep 30, 2020
69e79b6
Fixing format.
etdamiba-intel Sep 30, 2020
83d9811
Fixing format.
etdamiba-intel Sep 30, 2020
02cc3d1
Incorporating latest code review comments
etdamiba-intel Oct 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions sycl/plugins/level_zero/pi_level_zero.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2953,11 +2953,20 @@ piEnqueueKernelLaunch(pi_queue Queue, pi_kernel Kernel, pi_uint32 WorkDim,
zePrint("piEnqueueKernelLaunch: unsupported work_dim\n");
return PI_INVALID_VALUE;
}

assert(GlobalWorkSize[0] == (ZeThreadGroupDimensions.groupCountX * WG[0]));
assert(GlobalWorkSize[1] == (ZeThreadGroupDimensions.groupCountY * WG[1]));
assert(GlobalWorkSize[2] == (ZeThreadGroupDimensions.groupCountZ * WG[2]));


if(GlobalWorkSize[0] != (ZeThreadGroupDimensions.groupCountX * WG[0])) {
zePrint("piEnqueueKernelLaunch: invalid work_dim\n");
return PI_INVALID_WORK_GROUP_SIZE;
}
if(GlobalWorkSize[1] != (ZeThreadGroupDimensions.groupCountY * WG[1])) {
zePrint("piEnqueueKernelLaunch: invalid work_dim\n");
return PI_INVALID_WORK_GROUP_SIZE;
}
if(GlobalWorkSize[2] != (ZeThreadGroupDimensions.groupCountZ * WG[2])) {
zePrint("piEnqueueKernelLaunch: invalid work_dim\n");
return PI_INVALID_WORK_GROUP_SIZE;
}

ZE_CALL(zeKernelSetGroupSize(Kernel->ZeKernel, WG[0], WG[1], WG[2]));

// Get a new command list to be used on this call
Expand Down